[8.1.0] Symbolic macro Stardoc proto cherry picks #24607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs, and attribute inheritance Symbolic macros have a mandatory visibility attribute - we need to document it. To support attribute inheritance in documentation generation, it suffices to extract non-Starlark-defined attributes in macros, and expose the fact that they are non-Starlark-defined - so that a documentation renderer can provide a link to bazel.build common attributes for the natively defined common attributes that don't have a doc string. Take the opportunity to refactor addDocumentableAttributes() into a better shape (taking an explicit argument for the implicitly-added attributes), and fix the long-standing bug that Stardoc has been inserting a non-existent "name" attribute for aspects (which was partly obscured by the old addDocumentableAttributes() implementation). RELNOTES: Fix starlark_doc_extract proto output for symbolic macro visibility, attribute inheritance, and rule finalizers; and remove non-existent "name" attribute from starlark_doc_extract output for aspects. PiperOrigin-RevId: 700811908 Change-Id: I5486919b9e2af98a7d08f952f8075216c3c60bfd
…rable and natively defined. Follow-up fix to bazelbuild@59e99b6 PiperOrigin-RevId: 703255080 Change-Id: I1055c4c8b7e2e627199bdca9e2daab5654102831
tetromino
added
team-Documentation
github-actions
bot
added
team-Performance
|
@Wyverald I hear 8.0's release is imminent and my understanding is these changes are backwards compatible so we can retarget them to 8.1. Is the process to still merge into the release-8.0.0 branch, or has the final release not been cut yet?(We can also just keep this PR in limbo until after the release.) |
|
I marked this as soft-release-blocker because I wasn't sure when 8.0 was "really" going to be cut. This PR should not by itself block the release - but if there are any other blockers, I'd like this to go in too. |
iancha1992
changed the title
|
@bazel-io fork 8.0.1 |
|
Closing in favor of: #24644 |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of the following 2 commits, which collectively allow API documentation generation for symbolic macros using Stardoc:
Cherry-pick of
59e99b6
PiperOrigin-RevId: 700811908
Change-Id: I5486919b9e2af98a7d08f952f8075216c3c60bfd
Cherry-pick of
e6a44c8
PiperOrigin-RevId: 703255080
Change-Id: I1055c4c8b7e2e627199bdca9e2daab5654102831