Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to java_tools javac11 v4.0 #8960

Closed
wants to merge 3 commits into from

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Jul 23, 2019

RELNOTES: The new java_tools release:

  • fixes java_tools' ijar and singlejar don't build on windows #8614
  • exposes a new toolchain @java_tools//:prebuilt_toolchain which is using all the pre-built tools, including singlejar and ijar, even on remote execution. This toolchain should be used only when host and execution platform are the same, otherwise the binaries will not work on the execution platform.

@iirina iirina requested a review from meteorcloudy July 23, 2019 16:09
@iirina iirina added the team-Rules-Java Issues for Java rules label Jul 23, 2019
@iirina iirina requested a review from oquenchil July 24, 2019 07:14
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java_tools' ijar and singlejar don't build on windows
3 participants