Enable sandboxing and remote caching for the "exclusive" tag #8983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no good reason why tests tagged with exclusive shouldn't be able to use sandboxing and/or remote caching. The current limitations have been kept from open sourcing Bazel and have never been revisited since. Remote execution will continue to be disabled because Bazel can't control what else is running on a remote machine.
bazel-io
pushed a commit
that referenced
this pull request
Aug 5, 2019
*** Reason for rollback *** Breaks some Google-internal targets. *** Original change description *** Enable sandboxing and remote caching for the "exclusive" tag There's no good reason why tests tagged with exclusive shouldn't be able to use sandboxing and/or remote caching. The current limitations have been kept from open sourcing Bazel and have never been revisited since. Remote execution will continue to be disabled because Bazel can't control what else is running on a remote machine. Closes #8983. PiperOrigin-RevId: 261644804
katre
pushed a commit
that referenced
this pull request
Aug 7, 2019
*** Reason for rollback *** Breaks some Google-internal targets. *** Original change description *** Enable sandboxing and remote caching for the "exclusive" tag There's no good reason why tests tagged with exclusive shouldn't be able to use sandboxing and/or remote caching. The current limitations have been kept from open sourcing Bazel and have never been revisited since. Remote execution will continue to be disabled because Bazel can't control what else is running on a remote machine. Closes #8983. PiperOrigin-RevId: 261644804
katre
pushed a commit
that referenced
this pull request
Aug 12, 2019
*** Reason for rollback *** Breaks some Google-internal targets. *** Original change description *** Enable sandboxing and remote caching for the "exclusive" tag There's no good reason why tests tagged with exclusive shouldn't be able to use sandboxing and/or remote caching. The current limitations have been kept from open sourcing Bazel and have never been revisited since. Remote execution will continue to be disabled because Bazel can't control what else is running on a remote machine. Closes #8983. PiperOrigin-RevId: 261644804
|
@buchgr I know you no longer work on Bazel, but do you know if this could be conditionally enabled for Bazel? I understand that it was rolled back internally because of failing tests with internal backends. |
|
Sure, it is possible to conditionally enable it. In the best case, I would think of this approach as adding technical debt. In the worst case, it will lead to bugs in OSS projects that are synced between internal and external. Unless this feature is urgent, I'd recommend to invest the work and clean up depot. |
bazel-io
pushed a commit
that referenced
this pull request
Oct 15, 2020
1. Add --incompatible_exclusive_test_sandboxed flag so users can enable this feature conditionally. 2. Users who want to run exclusive tests locally can add a 'local' tag to the test. *** Original change description *** Enable sandboxing and remote caching for the "exclusive" tag There's no good reason why tests tagged with exclusive shouldn't be able to use sandboxing and/or remote caching. The current limitations have been kept from open sourcing Bazel and have never been revisited since. Remote execution will continue to be disabled because Bazel can't control what else is running on a remote machine. Closes #8983. *** PiperOrigin-RevId: 337219101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no good reason why tests tagged with exclusive shouldn't
be able to use sandboxing and/or remote caching. The current
limitations have been kept from open sourcing Bazel and have
never been revisited since.
Remote execution will continue to be disabled because Bazel
can't control what else is running on a remote machine.