Bazel compilation warnings mark the sync as "finished with some errors"

[jdai8]

Description of the bug:

#6813 seems to change how the sync status is displayed if the build had warnings. This happens even with the "New sync view" turned off.

This is confusing for users because it seems like sync did not complete successfully, when it actually did. If this is intended behavior, I think it would be useful to have a setting to configure it.

Which category does this issue belong to?

Intellij

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Run a sync where the build contains some compilation warnings. I reproduced this on an internal codebase but I think it should happen for any compilation warnings.

Before this change (and with it reverted):

After this change:

Which Intellij IDE are you using? Please provide the specific version.

IntelliJ 2024.3

What programming languages and tools are you using? Please provide specific versions.

Java, Kotlin

What Bazel plugin version are you using?

Built from source

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

[tpasternak]

Thank you Jack. I think we will have to hotfix that cc @LeFrosch

[LeFrosch]

Indeed, thanks reporting this. I'll take a look as soon as I can.

[LeFrosch]

Just checked it out myself with a build from master. In my case compilation warnings do not trigger similar behaviour. Could you share the actual warnings from the bazel errors view or logs?

[jdai8]

Thanks for taking a look. It might be something specific to our setup then. Let me try to reproduce on an open-source project.