Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASWB plugin does not properly handle the Starlark AndroidIdeInfo #7123

Open
Bencodes opened this issue Dec 5, 2024 · 3 comments
Open

ASWB plugin does not properly handle the Starlark AndroidIdeInfo #7123

Bencodes opened this issue Dec 5, 2024 · 3 comments
Assignees
@mai93
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: Android Studio Android Studio plugin type: bug

Comments

@Bencodes
Copy link

Bencodes commented Dec 5, 2024 •
edited
Loading

Description of the bug:

The aswb plugin checks for the native AndroidIdeInfo which is no longer being provided when you are using the rules_android rules. I'm told by the rules_android team that internally there's a check that prioritizes the newer starlark implementation of the AndroidideInfo provider, but is being stripped out during the copybara export process.
@Bencodes Bencodes added awaiting-maintainer Awaiting review from Bazel team on issues type: bug labels Dec 5, 2024
@tpasternak
Copy link
Contributor

cc @mai93

@mai93 mai93 self-assigned this Dec 6, 2024
@mai93
Copy link
Collaborator

mai93 commented Dec 6, 2024 •
edited
Loading

@Bencodes are you seeing this problem with the ASwB plugin for AS 2024.2 or 2024.3? Older AS versions are no longer supported. If it is on one of the supported versions, can you provide repro steps?

@Bencodes
Copy link
Author

Bencodes commented Dec 6, 2024

@mai93 it doesn't matter which version you use here, rules_android has moved over to a new AndroidIdeInfo provider that the open source aswb plugin doesn't know about.

A patch like this is needed to restore functionality for those that have moved over to rules_android: 017dd73

@satyanandak satyanandak added the product: Android Studio Android Studio plugin label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mai93 mai93

Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: Android Studio Android Studio plugin type: bug
Projects
Bazel IntelliJ Plugin
Status: Untriaged
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tpasternak @Bencodes @sgowroji @mai93 @iancha1992 @satyanandak