-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runfiles library to release archive #242
Conversation
@hvadehra I forgot to add the runfiles library to the release archive. |
How urgent is this? Do we want to add an integration test in https://github.com/bazelbuild/rules_java/tree/master/test/repo that would have caught something like this? |
I'm going to making another release shortly, so happy to merge this now, and get the test in later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the "for_bazel_tests" changes
It's needed for bazelbuild/bazel#24219. It's not a hard requirement for Bazel 8 from my point of view, but it could speed up the removal of ruleset deps from
I wasn't aware of this setup already existing. I will add a test as part of this PR as it is easy enough. |
@hvadehra I added a test. |
Could you please fix:
|
@hvadehra I ran |
No description provided.