Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runfiles library to release archive #242

Closed
wants to merge 5 commits into from

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 19, 2024

No description provided.

@fmeum fmeum requested review from comius and a team as code owners November 19, 2024 14:38
@fmeum
Copy link
Contributor Author

fmeum commented Nov 19, 2024

@hvadehra I forgot to add the runfiles library to the release archive.

@hvadehra
Copy link
Member

How urgent is this? Do we want to add an integration test in https://github.com/bazelbuild/rules_java/tree/master/test/repo that would have caught something like this?

@hvadehra
Copy link
Member

I'm going to making another release shortly, so happy to merge this now, and get the test in later.

Copy link
Member

@hvadehra hvadehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the "for_bazel_tests" changes

@fmeum fmeum requested a review from hvadehra November 19, 2024 15:21
@fmeum
Copy link
Contributor Author

fmeum commented Nov 19, 2024

How urgent is this?

It's needed for bazelbuild/bazel#24219. It's not a hard requirement for Bazel 8 from my point of view, but it could speed up the removal of ruleset deps from bazel_tools if it does get into the release.

Do we want to add an integration test in https://github.com/bazelbuild/rules_java/tree/master/test/repo that would have caught something like this?

I wasn't aware of this setup already existing. I will add a test as part of this PR as it is easy enough.

@fmeum
Copy link
Contributor Author

fmeum commented Nov 19, 2024

@hvadehra I added a test.

@hvadehra
Copy link
Member

Could you please fix:

Wrong order for java.nio.file.Path import. 
	//test/repo/src/MyTest.java:8:1
Extra separation in import group before 'mypackage.MyLib' [ImportOrder]
	//test/repo/src/MyTest.java:10:1
Extra separation in import group before 'com.google.devtools.build.runfiles.AutoBazelRepository' [ImportOrder]
	//test/repo/src/MyTest.java:15:1
Wrong order for com.google.devtools.build.runfiles.AutoBazelRepository import.
	//test/repo/src/MyTest.java:15:1

@fmeum
Copy link
Contributor Author

fmeum commented Nov 19, 2024

@hvadehra I ran google-java-format on the file, hope that solves the issues.

test/repo/src/MyTest.java Outdated Show resolved Hide resolved
@fmeum fmeum deleted the fix-runfiles branch November 19, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants