Skip to content

Commit

Permalink
chore: update Bazel minimum version to LTS
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
for our 4.0, rules_nodejs requires the current LTS of Bazel. This is a policy restriction to save us time tracking down support issues on older versions of Bazel, not a technical one. You can patch this check out locally if you really need to continue using older Bazel, but this puts you on unsupported track.
  • Loading branch information
alexeagle committed Jul 1, 2021
1 parent d2d4d16 commit a9c5966
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions internal/node/node_repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -773,15 +773,12 @@ def node_repositories(**kwargs):
**kwargs: the documentation is generated from the node_repositories_rule, not this macro.
"""

# 0.14.0: @bazel_tools//tools/bash/runfiles is required for nodejs
# 0.17.1: allow @ in package names is required for fine grained deps
# 0.21.0: repository_ctx.report_progress API
# 2.1.0: bazelignore support in external workspaces
# Require that users update Bazel, so that we don't need to support older ones.
check_bazel_version(
message = """
A minimum Bazel version of 2.1.0 is required to use build_bazel_rules_nodejs.
Bazel current LTS version (4.0.0) is the minimum required to use rules_nodejs.
""",
minimum_bazel_version = "2.1.0",
minimum_bazel_version = "4.0.0",
)

# This needs to be setup so toolchains can access nodejs for all different versions
Expand Down

0 comments on commit a9c5966

Please sign in to comment.