Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_npm .pack and .publish bins are broken [1.0.0 regression] #1493

Closed
alexeagle opened this issue Dec 20, 2019 · 0 comments · Fixed by #1494
Closed

pkg_npm .pack and .publish bins are broken [1.0.0 regression] #1493

alexeagle opened this issue Dec 20, 2019 · 0 comments · Fixed by #1494

Comments

@alexeagle
Copy link
Collaborator

See b4782b8#commitcomment-36523065 for the root cause.

As a workaround you can patch out this change. Put this content into rules_nodejs.patch in the root of your repo (next to WORKSPACE):

diff --git internal/pkg_npm/pkg_npm.bzl internal/pkg_npm/pkg_npm.bzl
index c6263521..76210bc0 100644
--- internal/pkg_npm/pkg_npm.bzl
+++ internal/pkg_npm/pkg_npm.bzl
@@ -86,6 +86,7 @@ def create_package(ctx, deps_sources, nested_packages):
         inputs = inputs,
         outputs = [package_dir, ctx.outputs.pack, ctx.outputs.publish],
         arguments = [args],
+        execution_requirements = {"local": "1"},
     )
     return package_dir

And then add to the http_archive(name = "build_bazel_rules_nodejs") in the WORKSPACE this attribute:

patches = ["//:rules_nodejs.patch"]

alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 20, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 20, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 20, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 20, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant