Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builtin): fixed missing dist targets #3068

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix(builtin): fixed missing dist targets #3068

merged 1 commit into from
Nov 8, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Nov 7, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3030

What is the new behavior?

This fixes broken behavior in the release tarball where users are no longer able to generate docs using stardoc.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Nov 7, 2021
@UebelAndre UebelAndre mentioned this pull request Nov 7, 2021
Closed
alexeagle
alexeagle approved these changes Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alexeagle alexeagle merged commit c30a26c into bazel-contrib:stable Nov 8, 2021
@UebelAndre UebelAndre deleted the dist branch November 8, 2021 03:58
@UebelAndre UebelAndre mentioned this pull request Nov 8, 2021
Merged
alexeagle pushed a commit that referenced this pull request Dec 3, 2021
@UebelAndre @alexeagle
fix(builtin): fixed missing dist targets (#3068)
6c13dac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @alexeagle