fix: guard node_modules roots for dynamic multi-linked npm deps #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
fix_dyn_BAZEL_NODE_MODULES_ROOTS
branch
from
1c4df60 to
7ab40b1
Compare
alexeagle
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
exports_directories_onlyall 3rd party deps are now linked npm deps.This fixes an issue where npm deps that are dynamically linked (not in the deps of a binary target) from non-root package_path in yarn_install and npm_install do not have their package_path added to
BAZEL_NODE_MODULES_ROOTS.BAZEL_NODE_MODULES_ROOTSis used to generated the list of patch roots for symlink escape protection. TL;DR is this fix ensures that all linked node_modules folders are guarded from symlink escapes.