Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace call to pip.main() #132

Closed
brandjon opened this issue Nov 13, 2018 · 3 comments
Closed

Replace call to pip.main() #132

brandjon opened this issue Nov 13, 2018 · 3 comments
Assignees
@brandjon
Labels
P3 type: bug

Comments

@brandjon
Copy link
Member

pip.main() was an internal function to the pip library that was commonly used as an entrypoint by client code. rules_python calls pip.main() here.

pip.main() is removed in current versions of pip. I believe this means that update_tools.sh will no longer work until we migrate.

Relevant pip threads:

pypa/pip#5080

pypa/pip#5149

pypa/pip#5254
@brandjon brandjon self-assigned this Nov 13, 2018
@brandjon
Copy link
Member Author

Actually piptool's deps are versioned, so this doesn't block us.

@brandjon brandjon added P3 and removed P1 labels Nov 13, 2018
@brandjon
Copy link
Member Author

See also #119.

@brandjon brandjon mentioned this issue Nov 13, 2019
Closed
@groodt
Copy link
Collaborator

groodt commented Feb 5, 2022

This can be closed. piptool.py was removed in #582 when the legacy pip_import rule was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandjon brandjon

Labels
P3 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @groodt @brandjon