pip import results in python3 incompatible libraries

[sha1n]

pip_import is using 'python' hardcoded, which in many cases (urllib2, psutil and several others) results in Python 2 libraries that are not compatible with Python 3.

I replaced "python" with "python3" in the following line and everything works perfectly on my environment.

rules_python/python/pip.bzl

Line 27 in 4b84ad2

"python",

Since this is blocking my team, I created a local copy of pip.bzl and patched it just for now. I'm not sure what is the appropriate way to approach this. If there is a way to get the PY/3 interpreter path from Bazel, a fair solution can be to add a python_version parameter to the import rule.

Seems like an essential feature for Python 3 support and I will be happy to contribute a PR if we can decide on a solution. WDYT?

[aaliddell]

There's a few open PRs about this issue, with varying solutions:

• Add a pip3_import target for Python 3 compatibility. #85
• Add optional attr python_interpreter to run pip with python 3 #158
• pip_import: Let users override system Python via PYTHON env var #179

There's also rules_pip, which offers a python_interpreter attribute to solve this on its pip_repository rule. This is the solution I have had to use until there's support in rules_python, although rules_pip actually subjectively has a nicer interface for using the fetched packages.

[sha1n]

Thanks @aaliddell! I was unaware of rules_pip and will definitely take a look.
Seems like #42 and #119 are also related to the same core issue, but I haven't seen any progress on either of them for a very long time.

I'll keep following.

[ali5h]

also check this https://github.com/ali5h/rules_pip_lock

[lshamis]

Python 2 will be officially past EOL come 2020: https://pythonclock.org/
This is an important issue to resolve before teams can start switching to Python 3.

[brandjon]

This should be resolved imminently. Dedupping this issue to #249.