Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to @rules_cc//cc:defs.bzl #2293

Merged
merged 18 commits into from
Nov 12, 2024

Conversation

comius
Copy link
Contributor

@comius comius commented Oct 11, 2024

Referring to @rules_cc//cc:defs.bzl, refers to @protobuf//bazel:cc_proto_library.bzl, which fetches protobuf repository.
Referring directly to what's needed limits the fetches just to rules_cc.

Fix reference to bzl libs in rules_cc that are needed for docs generation.

This requires rules_cc 0.0.13 or higher.

Work towards #2387, #2378

@meteorcloudy
Copy link
Member

I don't see any reason the RBE jobs have to build with Bazel 6.4.0 and ubuntu1604, please upgrade to Bazel 7.3.2 and ubuntu2204

@rickeylev
Copy link
Collaborator

We still support Bazel 6, so we should have an RBE for that. Do you mean for the Bazel 7 RBE job? It looks like its using 7.1 (which is a bit surprising; I thought our CI was setup to use 7.x, i.e. latest 7)

@meteorcloudy
Copy link
Member

I'm not sure which one is the Bazel 7 RBE job, but the for those RBE jobs, you should upgrade to rbe_ubuntu2004.

If Bazel 6 is still supported, then we need to fix rules_cc, sent bazelbuild/rules_cc#253

@aignas
Copy link
Collaborator

aignas commented Oct 13, 2024

FYI, once bazel 8 is out, we will start removing support for bazel 6, but if we can maintain compatibility in an easy way that wouldn't hurt. As for bazel version, we are defining it in .bazelversion in the rules_python repo, maybe we should remove that file to instead test with the latest available stable version?

rickeylev added a commit to rickeylev/rules_python that referenced this pull request Oct 20, 2024
This is per bazelbuild#2293 (comment)

From what I can tell ubuntu1604 is very old and not well supported.
@bazelbuild bazelbuild deleted a comment from Gray-null Oct 20, 2024
@rickeylev
Copy link
Collaborator

CI still show some failures, though. Some look related to compiling protobuf?

github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2024
This is per
#2293 (comment)

From what I can tell ubuntu1604 is very old and not well supported.
@rickeylev rickeylev added the need: upstream support An issue that needs changes in upstream code label Oct 21, 2024
@rickeylev
Copy link
Collaborator

Once #2379 is merged, I think this PR will be able to finally proceed. That PR drops Bazel 6 support and updates to rules_cc 0.0.14, which I think are prereqs for moving past rules_cc 0.0.9

@rickeylev rickeylev changed the title fix: remove references to @rules_cc//cc:defs.bzl chore: remove references to @rules_cc//cc:defs.bzl Nov 12, 2024
@rickeylev
Copy link
Collaborator

Updated to head, CI looking green. Looks like 2379 helped with this quite a bit.

@rickeylev rickeylev added this pull request to the merge queue Nov 12, 2024
Merged via the queue into bazelbuild:main with commit 576e6dc Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need: upstream support An issue that needs changes in upstream code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants