Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make bazel 9 workspace recognize rules_python as the main module #2501

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rickeylev
Copy link
Collaborator

@rickeylev rickeylev commented Dec 12, 2024

Building with Bazel 9 using WORKSPACE results in an odd error that PyInfo
isn't defined. Oddly, the error refers to rules_python/python/private/reexports.bzl
for rules_python 0.28.0. This seems to only happen when the main module is rules_python.

While Bazel 9 is supposed to drop workspace support, I've been advised it's better to
keep testing WORKSPACE support until closer to when Bazel 9 fully removes it.

My best guess about what's happening is Bazel's autoloading is triggering and somehow
defining rules_python before it's recognized that the main module is rules_python.
The autoloading appears to be triggered, eventually, by things in bazel_tools loading
rules_python.

While removing unnecessary @bazel_tools loads in rules_python helps, the particular
case I can't find a clean solution to is when
@@rules_java//toolchains:toolchain_java11_definition causes rules_python to be
loaded. This appears to end up loading rules_python via
@bazel_tools//tools/jdk:BUILD, which has has some py rules defined in it.

To fix/work around this issue, local_repository can be used to define the rules_python
repo before autoloading happens. This appears to take precedence over whatever logic
autoloading has.

Work towards #2469

@rickeylev rickeylev requested a review from aignas as a code owner December 12, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant