Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

同人システムの千幻抄を追加 #549

Merged
merged 5 commits into from
Aug 20, 2022

Conversation

h-mikisato
Copy link
Contributor

@h-mikisato h-mikisato commented May 26, 2022

https://wikiwiki.jp/sengensyou/

ダイスコマンドとしてクリティカル・ファンブルのある3D6の命中・回避判定のみ実装しました
https://discord.com/channels/597133335243784192/597133335243784194/978981650362937365

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #549 (23da11f) into master (84300e5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
+ Coverage   95.60%   95.61%   +0.01%     
==========================================
  Files         325      327       +2     
  Lines       19031    19075      +44     
==========================================
+ Hits        18195    18239      +44     
  Misses        836      836              
Impacted Files Coverage Δ
lib/bcdice/game_system.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/Sengensyou.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/GhostLive.rb 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ViVi-shark
Copy link
Contributor

👍

@ysakasin ysakasin merged commit d052631 into bcdice:master Aug 20, 2022
@ysakasin
Copy link
Member

@h-mikisato PRありがとうございます! マージしました

@ViVi-shark 細かい作法のレビューありがとうございます。

@h-mikisato h-mikisato deleted the feature/add_sengensyou branch November 27, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants