ArknightsTRPGのダイスボット追加 #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>D, B -> AD, AB >Increased test casees. > Enabled orthographical variants. eg, AN100<=10, AN<=10.
> Syndrome tables are added. > Dice result is sorted.
> Old functions (recentry unused) were removed. > Dice table was changed from array to hash.
> Remained old function was removed.
> Refined by rubocop.
> Reduce 'when' sections in func eval_game_system_specific_command().
> Comments by N.K was merged.
> Refined by Rubocop.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 95.63% 95.67% +0.03%
==========================================
Files 346 349 +3
Lines 20022 20276 +254
Branches 5250 5319 +69
==========================================
+ Hits 19148 19399 +251
- Misses 874 877 +3 ☔ View full report in Codecov by Sentry. |
|
@Ayase00 ありがとうございます。マージしました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArknightsTRPG (二次創作) のダイスボット追加リクエストです。
ダイステーブルについて、事情により自作を行いましたが、デフォルトのもので動作可能かつ必要と判断されましたらご指示を頂けますと幸いです。詳細につきましてはArknightsFan.rb line: 208, 209 を参照ください。