Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle driver misuse gracefully #353

Open
mhidalgo-bdai opened this issue Apr 16, 2024 · 0 comments
Open

Handle driver misuse gracefully #353

mhidalgo-bdai opened this issue Apr 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mhidalgo-bdai
Copy link
Collaborator

mhidalgo-bdai commented Apr 16, 2024

Feature description

The SpotROS ROS 2 driver node operates on the premise of proper use e.g. to release an eStop, an eStop must have been acquired. Failure to do so is met with cryptic exception messages. It would be beneficial for users if these cases were handled gracefully instead, with descriptive error messages.

Implementation considerations

Propagating SDK errors consistently and limiting ROS 2 service and action interfaces' operation to the robot states in which they are applicable (e.g. don't try to release an eStop if none has been acquired, don't try to move if the robot is powered down) would go a long way.

@mhidalgo-bdai mhidalgo-bdai added the enhancement New feature or request label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant