Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Localizations #213

Closed
IngeAlejandro opened this issue Mar 4, 2022 · 7 comments · Fixed by #357
Closed

Missing Localizations #213

IngeAlejandro opened this issue Mar 4, 2022 · 7 comments · Fixed by #357
Labels
enhancement New feature or request

Comments

@IngeAlejandro
Copy link

Is your feature request related to a problem? Please describe.
I want to use the library for an app in spanish, I was able to make a workaround for global tags but I can't translate de month in DatePicker.

Describe the solution you'd like
Allow more localizations or a locale parameter in DatePicker.

Describe alternatives you've considered
Current workaround is to extend DefaultLocalizations and overwrite all labels.

@bdlukaa bdlukaa added the enhancement New feature or request label Mar 4, 2022
@henry2man
Copy link
Contributor

henry2man commented Mar 5, 2022

@IngeAlejandro Nice one, I'm using the package in a Spanish localized app so I'm interested on this topic.

@bdlukaa @WinXaito Are you thinking of adding multi-language support? Maybe something based on the intl package or similar? Now that the package is gaining popularity this would be an interesting addition.

I think it would be good to make the package itself already integrate files with the translations, at least in the most common languages.

EDIT: I've just found #140... I reaffirm myself, I think it would be better to integrate a minimum l10n/i18n support within the app, which does not mean that each developer can continue to extend it with custom classes, just as RTL support is already being worked on #184

@WinXaito
Copy link
Collaborator

WinXaito commented Mar 5, 2022

I think it’s a good idea. In futur, I will need to provide app in multiple language (French, English, German, Italian and maybe Portuguese).

But honestly, I never do a big app localized, so I don’t really know how that’s work…

@henry2man
Copy link
Contributor

I've opened a branch on my fork and I'm going to try to make a prototype using arb files, which are easily maintainable.

If it goes well I will do a PR with the results

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 6, 2022

Awesome idea guys! @henry2man, please keep us posted! I'd love to do the translations to Portuguese

@henry2man
Copy link
Contributor

@bdlukaa Winter is comming :)

Captura de pantalla 2022-03-07 a las 9 44 03

henry2man added a commit to henry2man/fluent_ui that referenced this issue Mar 7, 2022
@henry2man
Copy link
Contributor

Hey folks, please take a look at #216

@bdlukaa bdlukaa mentioned this issue Mar 23, 2022
6 tasks
@henry2man
Copy link
Contributor

@IngeAlejandro Just wait for #236, because #216 already solved commonly used labels for Spanish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants