Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enforce static analysis #227

Merged
merged 5 commits into from
Mar 15, 2022
Merged

ci: enforce static analysis #227

merged 5 commits into from
Mar 15, 2022

Conversation

Ascenio
Copy link
Contributor

@Ascenio Ascenio commented Mar 14, 2022 •
edited
Loading

This PR enforces linting rules and code formatting by verifying each PR's commits.

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

OBS. 1: I've removed checks which are fulfilled by CI.
OBS. 2: I've not checked the required items because the changes made in this patch does not apply to the conditions. Also I've not updated the CHANGELOG.md because I don't think this changes anything from the client's perspective.

WinXaito
WinXaito approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@WinXaito WinXaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdlukaa bdlukaa merged commit b99d1f5 into bdlukaa:master Mar 15, 2022
@mesharkw mesharkw mentioned this pull request Jul 12, 2023
Closed
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
@dev-hann
ci: enforce static analysis (bdlukaa#227)
903ea60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

@WinXaito WinXaito WinXaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ascenio @WinXaito @bdlukaa