Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NavigationView Top mode #277

Merged
merged 14 commits into from
Apr 23, 2022
Merged

Improve NavigationView Top mode #277

merged 14 commits into from
Apr 23, 2022

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented Apr 9, 2022

#205

  • BREAKING Removed ItemsExtension, consequently removing the getPaneItemsOffsets method
  • BREAKING InheritedNavigationView.itemIndex has been renamed to InheritedNavigationView.currentItemIndex
  • Items in top mode now aren't rendered in a scrollable view. Instead, the DynamicOverflow widget, introduced on Implement command bars and dynamic overflow layout #232, is used to render the items

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have added/updated relevant documentation

@henry2man
Copy link
Contributor

henry2man commented Apr 22, 2022

@bdlukaa A question regarding this component with ".top" setting. Is the position of the InfoBadge at the top right intentional? Could it be parameterized?

I am creating an email-like UI and the badges in that position are weird (They would probably look better placed to the right and center)

@bdlukaa
Copy link
Owner Author

bdlukaa commented Apr 23, 2022

@henry2man I also think so. I believe some property like InfoBadgePosition can be added, in another PR after this one.

@bdlukaa bdlukaa marked this pull request as ready for review April 23, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants