Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indent_inner_html not working in v1.8.0 #1514

Closed
gabrielmaldi opened this issue Aug 27, 2018 · 1 comment
Closed

indent_inner_html not working in v1.8.0 #1514

gabrielmaldi opened this issue Aug 27, 2018 · 1 comment
Labels
good first issue language: html type: bug
Milestone
v1.8.1

Comments

@gabrielmaldi
Copy link
Contributor

Description

indent_inner_html: true seems to be ignored in v1.8.0

Input

The code looked like this before beautification:

<!DOCTYPE html>
<html>
<head>
<title>Title</title>
</head>
<body>
Body
</body>
</html>

Expected Output

The code should have looked like this after beautification:

<!DOCTYPE html>
<html>

    <head>
        <title>Title</title>
    </head>

    <body>
        Body
    </body>

</html>

Actual Output

The code actually looked like this after beautification:

<!DOCTYPE html>
<html>

<head>
    <title>Title</title>
</head>

<body>
    Body
</body>

</html>

Environment

https://beautifier.io/

Settings

Example:

{
    "indent_inner_html": true
}
@gabrielmaldi gabrielmaldi mentioned this issue Aug 27, 2018
Closed
@bitwiseman
Copy link
Member

bitwiseman commented Aug 27, 2018 •
edited
Loading

Right, this setting got lost in 1.8.0. I see why, it was not well documented and was implemented in a very strange way. This should be implemented the same way that indent_body_inner_html and indent_head_inner_html are implemented (though its default is false rather than true). Obviously, also needs tests (since the issue wasn't caught before release).

@bitwiseman bitwiseman added this to the v1.8.1 milestone Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue language: html type: bug
Projects
None yet
Milestone
v1.8.1
Development

No branches or pull requests
2 participants
@bitwiseman @gabrielmaldi