Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globs no longer work on Windows in 1.14.5 #2093

Closed
HitkoDev opened this issue Aug 19, 2022 · 3 comments · Fixed by #2094
Closed

Globs no longer work on Windows in 1.14.5 #2093

HitkoDev opened this issue Aug 19, 2022 · 3 comments · Fixed by #2094
Labels
implementation: javascript type: bug
Milestone
v1.14.6

Comments

@HitkoDev
Copy link
Contributor

Description

Glob 8, introduced in 1.14.5, now treats backslashes (\) in input as escape characters (https://github.com/isaacs/node-glob/blob/main/changelog.md#80). Nopt on Windows expands paths passed as arguments to contain backslashes, so they no longer get matched by glob.
@HitkoDev
Copy link
Contributor Author

@bitwiseman e7c9dcb

@bitwiseman
Copy link
Member

@HitkoDev
A PR to fix this would be great. This made it in because the Windows CI builds were failing for other reasons.

@HitkoDev HitkoDev mentioned this issue Aug 19, 2022
Merged
6 tasks
@bitwiseman bitwiseman added this to the v1.14.6 (Next Release) milestone Aug 21, 2022
@bitwiseman
Copy link
Member

@HitkoDev
Thanks! Releasing the new version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implementation: javascript type: bug
Projects
None yet
Milestone
v1.14.6
Development

Successfully merging a pull request may close this issue.

Fix Windows glob issue HitkoDev/js-beautify
2 participants
@bitwiseman @HitkoDev