Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function * fn() {} -> function* fn() {} #908

Open
mathieug opened this issue Mar 29, 2016 · 5 comments
Open

function * fn() {} -> function* fn() {} #908

mathieug opened this issue Mar 29, 2016 · 5 comments

Comments

@mathieug
Copy link

Since I've updated from 1.5.1 to 1.6.2, I've this behaviour:
function * fn() {}
becomes
function* fn() {}

@bitwiseman bitwiseman added this to the v1.6.3 milestone Mar 30, 2016
@mathieug
Copy link
Author

The issue appears in v1.5.2.

@bitwiseman bitwiseman modified the milestones: v1.6.3, v1.6.4 Jun 3, 2016
@mathieug
Copy link
Author

Hello @bitwiseman. Any news? I tried to read the code and fix this issue myself but it's really not easy.

@bitwiseman
Copy link
Member

This behavior is actually by design per #428. Adding the ability to control the space around the * is a bit more involved. I'm going to have to push this to the next release.

See #920. The changes made to fix that would be where changes would need to start.

@bitwiseman bitwiseman modified the milestones: v1.6.5, v1.6.4 Aug 29, 2016
@mathieug
Copy link
Author

Hello @bitwiseman, any news? Do we just want to add a condition around the one added on 98b3c53?

@bitwiseman
Copy link
Member

@mathieug - I've been too busy to get to this (obviously). The project could really use any help you can offer. If you have time to submit a PR with tests that would be great. Thanks!

@bitwiseman bitwiseman modified the milestones: v1.7.x, v1.6.5 Dec 21, 2016
@bitwiseman bitwiseman modified the milestones: v1.9.x, v1.10.x Apr 29, 2019
@bitwiseman bitwiseman modified the milestones: v1.10.x, v1.10.xx Jan 14, 2020
@bitwiseman bitwiseman modified the milestones: v1.10.x, v1.11.x Apr 5, 2020
@bitwiseman bitwiseman modified the milestones: v1.11.x, v1.12.x Aug 13, 2020
@bitwiseman bitwiseman modified the milestones: v1.12.x, 1.13.x Aug 20, 2020
@bitwiseman bitwiseman modified the milestones: v1.13.1, v1.13.x Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants