Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LESS mixin fix #1664

Merged
merged 6 commits into from
Apr 28, 2019
Merged

LESS mixin fix #1664

merged 6 commits into from
Apr 28, 2019

Conversation

HanabishiRecca
Copy link
Contributor

@HanabishiRecca HanabishiRecca commented Apr 20, 2019 •
edited
Loading

Description

Fixes Issue:
#1018
#1582
#842

@HanabishiRecca
Copy link
Contributor Author

@bitwiseman, check this.

bitwiseman
bitwiseman reviewed Apr 22, 2019
View reviewed changes
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first review my response is "wow". I am impressed. This is a very small change to fix these issues.

I think some additional tests are needed for variations on these inputs. I'll add them today.

js/src/css/beautifier.js Outdated Show resolved Hide resolved
js/src/css/beautifier.js Outdated Show resolved Hide resolved
@HanabishiRecca
Copy link
Contributor Author

HanabishiRecca commented Apr 22, 2019 •
edited
Loading

@bitwiseman, alright now parenLevel can't be negative.

@bitwiseman
Copy link
Member

@HanabishiRecca
I added tests. One to verify the parenthesis change and one for indenting of parenthesis contents.

@bitwiseman bitwiseman merged commit 0cea554 into beautifier:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HanabishiRecca @bitwiseman