Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Additional filter for items #26

Closed
ds2268 opened this issue May 8, 2017 · 5 comments
Closed

[Request] Additional filter for items #26

ds2268 opened this issue May 8, 2017 · 5 comments

Comments

@ds2268
Copy link
Contributor

ds2268 commented May 8, 2017

Hi @benfred,

Can you add in the official library the option for recommend method to accept additional list of items, that you don't want to include in the recommendations. Therefore we would still get for example top N items (excluding the items from given list) instead of filtering afterwards where you prune given recommendations and get less than the number of requested recommendations.

Thanks!

@benfred
Copy link
Owner

benfred commented May 8, 2017

This shouldn't be too hard to add - we are already filtering out items that the user has viewed from the result set: https://github.com/benfred/implicit/blob/master/implicit/als.py#L88-L89 and extending that for other items should be pretty easy.

@ds2268
Copy link
Contributor Author

ds2268 commented May 8, 2017

@benfred I agree, I can prepare PR because I need this functionality anyway :)

@ds2268
Copy link
Contributor Author

ds2268 commented May 12, 2017

@benfred thank you for your fast response. It is possible to make this version accessible through pip repository. I guess new version tag is needed for this.

@benfred
Copy link
Owner

benfred commented May 12, 2017

You're right - the version needs updated and I need to push changes to pypi.

I'll do this this weekend - I won't really have an opportunity before tomorrow night.

@benfred
Copy link
Owner

benfred commented May 14, 2017

I've bumped the version number here, and pushed to pypi: a50fb1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants