Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated docstring for AlternatingLeastSquares.fit #334

Closed
madcat1991 opened this issue Mar 18, 2020 · 1 comment
Closed

Outdated docstring for AlternatingLeastSquares.fit #334

madcat1991 opened this issue Mar 18, 2020 · 1 comment

Comments

@madcat1991
Copy link

Hi @benfred ,

It seems that the documentation for AlternatingLeastSquares.fit is slightly outdated. In particular the part related to the item_users parameter:

The negative items are implicitly defined: This code assumes that non-zero items in the item_users matrix means that the user liked the item. The negatives are left unset in this sparse matrix: the library will assume that means Piu = 0 and Ciu = 1 for all these items.

According to the issue #119 and this diff it is possible now to provide negative Ciu values to take into account explicit negative feedback.

If so, then the documentation should be updated.

@madcat1991 madcat1991 changed the title Outdates docstring for AlternatingLeastSquares.fit Outdated docstring for AlternatingLeastSquares.fit Mar 18, 2020
@benfred
Copy link
Owner

benfred commented Apr 12, 2020

Thanks! updated the docstring here: ee95496

@benfred benfred closed this as completed Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants