Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description image property #42

Merged
merged 2 commits into from
Sep 29, 2017

Conversation

jakub-tucek
Copy link
Contributor

@jakub-tucek jakub-tucek commented Sep 24, 2017

Hey, like this library. One thing I am missing is option to add image description, so I implemented it (with demo).

Please let me known, if it's ok to use it or I will have to use fork / find another lib in future. Thanks.

Cheers

@benhowell
Copy link
Owner

Hi,
Can you describe in greater detail what this feature does? Have you got a demo I can see?

Thanks.

@jakub-tucek
Copy link
Contributor Author

Hi,

There is demo5 in PR. Or you want some kond of direct link?

This pr adds option to add description (string or element) to object representing image. Description is then shown below image.

For example: in my case, I need to show title of image and author name. (And cant do it in overlay)

@benhowell
Copy link
Owner

Link or screenshot would be good as it saves me from merging the pull request, then packaging and deploying to test in order to see the demo ;-)

@jakub-tucek
Copy link
Contributor Author

Here is screenshot from new demos page:

image

@benhowell benhowell merged commit 13fdf6b into benhowell:master Sep 29, 2017
@benhowell
Copy link
Owner

Thanks very much for that.
I've changed the prop name from description to thumbnailCaption for consistency with the other props.

Released in v0.4.4 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants