Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack] not resolving imports with resource query #357

Closed
daltones opened this issue May 27, 2016 · 3 comments
Closed

[webpack] not resolving imports with resource query #357

daltones opened this issue May 27, 2016 · 3 comments

Comments

@daltones
Copy link
Contributor

There are not many loaders that use this feature, but Webpack provides the resource query besides the loader query (inside the loader context: this.resourceQuery besides this.query). Like this:

// common loader query
import Foo from 'some-loader?param=value!module-path.js';

// loader query and resource query
import Bar from 'some-loader?param=value!module-path.js?otherParam=otherValue';

Currently Webpack Resolver doesn't understand resource queries and cannot resolve module-path.js properly.

@benmosher
Copy link
Member

Ah, yep. It knows to omit the loader bits, but I don't recall handling the query.

Shouldn't be too tough to add in.

@benmosher
Copy link
Member

FYI, just (finally!) published with v0.3.2 of the resolver.

@daltones
Copy link
Contributor Author

Good! Thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants