Fixes #411 #413
Merged
Fixes #411 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Looks good at first glance, I just need to check out the test failures and take a closer look at the Webpack spec. |
|
Finally looked at the spec. No good docs on |
| @@ -14,7 +14,7 @@ module.exports = { | |||
| { 'jquery': 'jQuery' }, | |||
| 'bootstrap', | |||
| function (context, request, callback) { | |||
| if (request === 'underscore') { | |||
| if (request === 'underscore' && context.indexOf('/') !== -1) { | |||
There was a problem hiding this comment.
@Satyam: can you explain why this extra predicate? seems to be unnecessary on OSX, and I think it might be why the tests fail on Windows?
There was a problem hiding this comment.
It is just to force an error when context is null since null has no indexOf method. Whatever produces an error when context is null would do just as well, just to make sure the fix is not reversed later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.js contains the fix
webpack.config.js contains code that trips an error if fix not present.
Initial git clone test gave two errors which are not related to this fix.