-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gradio integration #5008
Merged
Merged
feat: gradio integration #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parano
requested review from
frostming and
larme
and removed request for
a team and
frostming
October 6, 2024 10:13
aarnphm
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want frost opinion on this:
For any integration going forward, should it be under bentoml._internal
or _bentoml_sdk
?
I think it should be the second option?
frostming
reviewed
Oct 10, 2024
aarnphm
reviewed
Oct 10, 2024
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
Signed-off-by: Frost Ming <[email protected]>
frostming
force-pushed
the
gradio-integration
branch
from
October 11, 2024 01:33
278b89d
to
e2e6b6b
Compare
frostming
approved these changes
Oct 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
This PR simplifies how users can serve Gradio UI for their BentoML service. Previously user will need to manually do multiple settings and callbacks, e.g.:
With this PR, this can be simplified as:
Before submitting:
guide on how to create a pull request.
pre-commit run -a
script has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.