Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin pydantic to < 2.10 and restore cwd when building bento #5093

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming [email protected]

What does this PR address?

Fixes #(issue)

Before submitting:

@frostming frostming requested a review from a team as a code owner November 21, 2024 02:28
@frostming frostming requested review from parano and removed request for a team November 21, 2024 02:28
@aarnphm
Copy link
Contributor

aarnphm commented Nov 21, 2024

what was the issue for this?

@frostming
Copy link
Contributor Author

frostming commented Nov 21, 2024

what was the issue for this?

When we build bento in Python code, it should better restore the cwd or it may cause problems, especially when the build ctx is a temp dir and gets destroyed after done.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming changed the title fix: set standalone_build to False to allow build many times fix: pin pydantic to < 2.10 and restore cwd when building bento Nov 21, 2024
Signed-off-by: Frost Ming <[email protected]>
@bojiang bojiang merged commit eb15e32 into bentoml:main Nov 21, 2024
51 checks passed
@frostming frostming deleted the fix/standalone-build branch November 28, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants