fix: yarn.lock is missing when compiling the package as a dependency #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: D4ryl00 <[email protected]>
D4ryl00
force-pushed
the
fix/yarnlock
branch
from
ffc7e89
to
ef36410
Compare
D4ryl00
changed the title
D4ryl00
changed the title
jefft0
previously approved these changes
Nov 25, 2024
jefft0
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
To reproduce the bug in issue #23, I did:
npx create-expo-app@latest testexpo
cd testexpo
npx expo install @berty/weshnet-expo
npx expo prebuild --clean -p ios
It prints the error No rule to make target yarn.lock', needed by node_modules' .
To test the fix in the PR, I did:
cd
git clone https://github.com/D4ryl00/weshnet-expo --branch fix/yarnlock
cd weshnet-expo
make
npm pack
cd ..
rm -rf testexpo
npx create-expo-app@latest testexpo
cd testexpo
npm install ../weshnet-expo/berty-weshnet-expo-0.0.2.tgz
npx expo prebuild --clean -p ios
It builds without error.
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23
Like
package-lock.json,yarn.lockwill be ignore if not present to the root folder:One key detail about package-lock.json is that it cannot be published, and it will be ignored if found in any place other than the toplevel package.https://docs.npmjs.com/cli/v6/configuring-npm/package-lock-json
So just make it optional from the Makefile.