Update FF field names to match #10670 #506
Conversation
|
SonarCloud Quality Gate failed.
|
| 'debug[0]':'Setpoint Delta Impl [Roll]', | ||
| 'debug[1]':'Boost Amount', | ||
| 'debug[2]':'Boost Amount Clip [Roll]', | ||
| 'debug[3]':'Clip', | ||
| 'debug[0]':'Raw FF Derivative [Roll]', | ||
| 'debug[1]':'Cleaned FF Derivative ', | ||
| 'debug[2]':'Cleaned Boost Amount [Roll]', | ||
| 'debug[3]':'Duplicate Marker', |
There was a problem hiding this comment.
Here we have the habitual nightmare of the blackbox and configurator... we need to maintain backward compatibility :(
I don't remember to have done this before for the debug names, so I can't point to a sample at this moment... but if the "old" name is correct for old logs, then we can't simply rename them.
There was a problem hiding this comment.
I see.
The current names aren't quite right in a lot of debug cases. In this case the existing names aren't right for 4.2 either :-)
If its tough to provide a compatibility solution for the debugs, could we make 'releases' that are correct for a given version of the software, in terms of debug names and waveform scaling ?
There was a problem hiding this comment.
I doubt. A lot of people have different quads some of them in different versions, and expect all to be working... @mikeller what do you think in this case?
I cant try to look at the code this week to see if we can make this conditional depending on the version.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
|
I've tried a number of things to get blackbox to respond to a change in the names of fields when the debug name hasn't changed. |
|
Can be closed since #514 provided version control for debug names and included fixing the feedforward names. Thanks @McGiverGim |
Update Blackbox Log viewer field names to reflect the debug changes in #10670