Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FF field names to match #10670 #506

Closed
wants to merge 1 commit into from
Closed

Update FF field names to match #10670 #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions js/flightlog_fields_presenter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,10 @@ function FlightLogFieldPresenter() {
},
'FF_INTERPOLATED' : {
'debug[all]':'FF Interpolated',
'debug[0]':'Setpoint Delta Impl [Roll]',
'debug[1]':'Boost Amount',
'debug[2]':'Boost Amount Clip [Roll]',
'debug[3]':'Clip',
'debug[0]':'Raw FF Derivative [Roll]',
'debug[1]':'Cleaned FF Derivative ',
'debug[2]':'Cleaned Boost Amount [Roll]',
'debug[3]':'Duplicate Marker',
Comment on lines -414 to +417
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have the habitual nightmare of the blackbox and configurator... we need to maintain backward compatibility :(

I don't remember to have done this before for the debug names, so I can't point to a sample at this moment... but if the "old" name is correct for old logs, then we can't simply rename them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

The current names aren't quite right in a lot of debug cases. In this case the existing names aren't right for 4.2 either :-)

If its tough to provide a compatibility solution for the debugs, could we make 'releases' that are correct for a given version of the software, in terms of debug names and waveform scaling ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt. A lot of people have different quads some of them in different versions, and expect all to be working... @mikeller what do you think in this case?
I cant try to look at the code this week to see if we can make this conditional depending on the version.

},
'RTH' : {
'debug[all]':'RTH',
Expand Down