Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would you consider a PL for adding -X in pm2 #23

Open
MiroRadenovic opened this issue Sep 23, 2014 · 2 comments
Open

would you consider a PL for adding -X in pm2 #23

MiroRadenovic opened this issue Sep 23, 2014 · 2 comments

Comments

@MiroRadenovic
Copy link
Contributor

i have just started using pm2 and gunt-ec2 and i have incurred in a a bug with pm2.
the bug is reported here:
Unitech/pm2#731 (comment)
Unitech/pm2#74

for me, the solution for this is to run pm in fork_mode, by adding the paramenter -X to pm2.
please note that i am running a single core ec2, so basically, for my case, there is no difference in using cluster_mode or fork_mode.

would grunt-ec2 benefits of adding the param -X (through conf) when runing pm2? or other issues can happen by adding this features?

please let me know and if you think this can be an improvement, and in case of yes, I will PR
thx

@bevacqua
Copy link
Owner

Yes. This sounds like the sensible thing to do. FWIW I moved to using bash scripting instead, and in that version of the same code I use recluster to get cluster functionality with hot code reloads.

https://github.com/ponyfoo/ponyfoo/tree/redo/build/ec2

@MiroRadenovic
Copy link
Contributor Author

i have added the -x param : #25
please note that this also includes commits from PL #24

if you don't like my changes feel free to only merge the #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants