Use a int64 for Unix time to make this code 2038 proof. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjojo
reviewed
Dec 19, 2023
|
Ah, TIL, Just tested it ( https://go.dev/play/p/vKlhXmbS_cu ) and you are
right
…On Tue, Dec 19, 2023 at 5:17 PM Job Snijders ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/stayrtr/stayrtr.go
<#106 (comment)>:
> @@ -208,7 +208,7 @@ func processData(vrplistjson []prefixfile.VRPJson,
// grab the current time every time it's invoked, time calls can be slow on
// some platforms, so lets just get the unix time when we start and use that
// to compare it all
- NowUnix := time.Now().UTC().Unix()
It’s implied in .Unix(), no?
—
Reply to this email directly, view it on GitHub
<#106 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALPK4RAUIRBAKXSAKRWFTDYKHD4NAVCNFSM6AAAAABA3NY4KKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBZGM3TCNBSGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting
Time.Unix()down to anintis going to be a problem "soon".Just use int64 in the JSON structs this will move the issue out to a generation that hopefully no longer suffers from using golang, JSON and especially RPKI.