Avoid adding empty deltas to the cache #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns false and aborts the data addition if there is no change in the delta. Use this to shortcut applyUpdateFromNewState() which prevents sending out notifications for empty deltas.
ties
requested changes
Feb 29, 2024
cmd/stayrtr/stayrtr.go
Outdated
| @@ -445,10 +445,13 @@ func (s *state) applyUpdateFromNewState(vrps []rtr.VRP, brks []rtr.BgpsecKey, va | |||
| for _, v := range vaps { | |||
| SDs = append(SDs, v.Copy()) | |||
| } | |||
| s.server.AddData(SDs) | |||
| if (s.server.AddData(SDs) == false) { | |||
There was a problem hiding this comment.
Suggested change
| if (s.server.AddData(SDs) == false) { | |
| if !s.server.AddData(SDs) { |
ties
reviewed
Feb 29, 2024
lib/server.go
Outdated
| @@ -373,7 +373,12 @@ func (s *Server) AddData(new []SendableData) { | |||
| curDiff := append(added, removed...) | |||
| s.sdlock.RUnlock() | |||
|
|
|||
| s.AddSDsDiff(curDiff) | |||
| if (len(curDiff) == 0) { | |||
There was a problem hiding this comment.
Suggested change
| if (len(curDiff) == 0) { | |
| if len(curDiff) == 0 { |
I think gofmt would have applied this automatically
ties
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return true or false from AddData().
Returns false and aborts the data addition if there is no change in the delta.
Use this to shortcut applyUpdateFromNewState() which prevents sending out notifications for empty deltas.
While detecting no file change for slurm using a hash (#115) prevents this case it still is an extra safety to prevent empty deltas to show up.