Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codeql actions #35

Merged
merged 5 commits into from
Oct 25, 2021
Merged

Add codeql actions #35

merged 5 commits into from
Oct 25, 2021

Conversation

ties
Copy link
Collaborator

@ties ties commented Oct 25, 2021

  • Set go version to 1.16 minimum in CI file (think this was mentioned in a recent PR)
  • Add codeql scanning action
  • Fix three linter errors it found

Alternatively https://golangci-lint.run/ also looks good, but I do not have experience with that tool.

ties added 5 commits October 25, 2021 19:54
@ties
golang 1.16
fa2fb29
@ties
add codeql scanning
a8759ef
@ties
Use local variable for password, not argument
0a9217a 
Use the local variable (possibly containing a password from the
environment) for the SSH password.
@ties
check for err
e5c5a99
@ties
Remove ineffectual assign
041a1c5
@job job merged commit fb912e5 into master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ties @job