Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String selector in CSS flags as issue in our sonarqube.org scans #293

Closed
markkes opened this issue Oct 5, 2021 · 3 comments
Closed

String selector in CSS flags as issue in our sonarqube.org scans #293

markkes opened this issue Oct 5, 2021 · 3 comments

Comments

@markkes
Copy link

markkes commented Oct 5, 2021

Describe the bug
String selector in CSS flags as issue in our sonarqube.org scans. Its the ".glightbox-mobile .glightbox-container .gslide-desc string" selector in the provided css file.

Screenshots
Screenshot 2021-10-05 at 10 32 15

Could you explain/look in to this selector. I cant find a reason where this selector is needed since i cant find this html element in the code so i dont know why/where its used. If it is used can you rewrite it to a class?

@gingerchew
Copy link
Collaborator

Hey @markkes,

You are right, there is a weird selector in our src file. I'm not sure why that is in there.

Just for our own notes it's on line 363 of the src css file.

I'm sure it can just be removed, I just don't have time to test it right now.

Thanks for spotting that and letting us know!

@markkes
Copy link
Author

markkes commented Oct 5, 2021

@Frankie-tech Awesome, thanks for the quick reply. There are also multiple duplicate properties in the css that flag in sonarqube. Examples are:

  • overflow in selector glightbox-container on line 6
  • opacity in selecter on line 46
  • margin in selector img on line 145
  • display in selector &::before on line 207
  • background in selector gslide-description on line 332

@biati-digital
Copy link
Owner

This should be fixed in 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants