Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oapply doesnt work for symbolic arguments #18

Closed
carocad opened this issue Apr 27, 2018 · 1 comment
Closed

oapply doesnt work for symbolic arguments #18

carocad opened this issue Apr 27, 2018 · 1 comment

Comments

@carocad
Copy link

carocad commented Apr 27, 2018

Hey guys,
first of all thanks a lot for this awesome project. I have only heard good things about it so I started using it recently.

However I was faced with an error that I cannot get my head around. I am not sure if this is just not the intended use or if this is a bug in the library, so here it is.

If I have something like (oops/apply+ object f args) oops will complain that args is not a sequence. My guess is that it is trying to check this at compile time, however I only know the args value at runtime, just as with the rest of the arguments 😞

Is this a bug or just not an intended use case?

@darwin
Copy link
Member

darwin commented Apr 27, 2018

I confirm this is a bug. Actually it is a problem in fspecs guarding our macros:

(def oapply-args [:selector (s/+ anything?) :args sequential?])

The :args should be anything? there I guess. If you find a way how to redefine fspec or disable it temporarily that could be a good workaround, because I believe that the library code should work.

I won't get to fixing this until next week.

@darwin darwin closed this as completed in bc27497 May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants