BiT system tray icon process may use wrong config file and share path due to missing --config and --share-path arguments

[aryoda]

Observation

Backintime CLI allows

• to pass the path to a backup config file via the --config argument
• and to pass the location of the lock and status files via the --share-path argument:

backintime/common/backintime.py

Lines 141 to 154 in e22c7f2

	#define config argument
	configArgsParser = argparse.ArgumentParser(add_help = False)
	configArgsParser.add_argument('--config',
	metavar = 'PATH',
	type = str,
	action = 'store',
	help = 'Read config from %(metavar)s. ' +
	'Default = ~/.config/backintime/config')
	configArgsParser.add_argument('--share-path',
	metavar = 'PATH',
	type = str,
	action = 'store',
	help = 'Write runtime data (locks, messages, log and mountpoints) to %(metavar)s.')

If the system tray icon plugin is installed the values of the --config and --share-path arguments are not passed to newly spawned system tray icon process:

backintime/qt/plugins/qt4plugin.py

Lines 54 to 55 in e22c7f2

	path = os.path.join(tools.backintimePath('qt'), 'qtsystrayicon.py')
	self.process = subprocess.Popen([sys.executable, path, self.snapshots.config.currentProfile()])

Impact

• The system tray icon may not be shown at all since no lock file is found (which indicates a running backup job)
• Unit tests do not show the system tray icon or do show the wrong progress status if a backup job is running for the already installed BiT. E.g. this unit test:
  

  backintime/common/test/test_backintime.py

  Lines 111 to 117 in e22c7f2

  	# execute backup and verify output
  	proc = subprocess.Popen(["./backintime",
  	"--config", "test/config",
  	"--share-path", self.sharePath,
  	"backup"],
  	stdout=subprocess.PIPE,
  	stderr=subprocess.PIPE)

Expected Behavior

• Pass the --config and --share-path arguments from backintime to the system tray icon process
• The system tray icon process must parse and use the values if the arguments are passed

[aryoda]

Could be fixed together with the master issue #1306 or separately...

[aryoda]

There are also other code locations that ignore the --config argument, mainly everything that directly or indirectly spawns a sub process passing a config id is under suspicion, e.g.:

• backintime/common/sshtools.py

  Lines 313 to 316 in e22c7f2

  	env = os.environ.copy()
  	env['SSH_ASKPASS'] = 'backintime-askpass'
  	env['ASKPASS_PROFILE_ID'] = self.profile_id
  	env['ASKPASS_MODE'] = self.mode

[buhtz]

Just an idea without knowing the details. But if it is possible it would be the cleanest if systrayicon.py never touch the the config file. Maybe all needed config values should be handed over via arguments. Don't know how much arguments that have to be.