Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use a single scorer for each sim_node impl of Lightning Node #216

Open
carlaKC opened this issue Feb 4, 2025 · 0 comments
Open
Labels
feature New feature or request

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Feb 4, 2025

As is: The LightningNode impl for SimNode will create a new scorer every time it sends a payment.

To Be: scorer should be stored in SimNode and passed to pathfinding for re-use.

Motivation: our pathfinding heuristics start from fresh every time we send a payment, which makes pathfinding very dumb (it doesn't remember any of our previous attempts because we just throw them away). To better match reality we should track scores across payments.

While we're here:

  • It could be nice to look into the payment parameters used by LDK and perhaps set something other than the default (if it makes sense). I've just never had the time but perhaps we can do something smarter here.
@carlaKC carlaKC added the feature New feature or request label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant