Introduce canonicalization modifiers. #1808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `CanonicalizationMods` which is passed in to `CanonicalIter::new`. `CanonicalizationMods::assume_canonical` is the only field right now. This contains a list of txids that we assume to be canonical, superceding any other canonicalization rules.
Also change `TxTemplate` API to allow for testing with `assume_canonical`.
evanlinjin
force-pushed
the
superimposed_canonicalization
branch
from
4169060 to
0f00cdb
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #1748
Description
Add the ability to modify the canonicalization algorithm. Right now, the only modifier is
assume_canonicalwhich takes in aVec(ordered list) of txids and superimposes it on the canonicalization algorithm. Txs later in the list (higher index) have a higher priority (in case of conflicts).This is a "partial fix" because I haven't figured out how to expose this on the
bdk_walletlevel yet (some thoughts on this will be very appreciated).Notes to the reviewers
None at the moment.
Changelog notice
CanonicalizationModsto allow the caller to modify the canonicalization algorithm. This in a new parameter onCanonicalIter::new.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: