Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] get_funded_wallet() does not return balance #719

Closed
rajarshimaitra opened this issue Aug 15, 2022 · 0 comments · Fixed by #726
Closed

[bug] get_funded_wallet() does not return balance #719

rajarshimaitra opened this issue Aug 15, 2022 · 0 comments · Fixed by #726
Assignees
Labels
bug Something isn't working

Comments

@rajarshimaitra
Copy link
Contributor

Describe the bug
After recent changes in balance calculation, the get_funded_wallet test function will not show any balance because we are not setting the sync_time in the populate_test_db macro..

Our existing tests are not failing, because even if the balance is shown zero, it will still be able to produce transactions. But its causing test failure in downstream bdk-reserves crate where the balances are required to assert scenarios.

To Reproduce

let (wallet, _, _) = get_funded_wallet(get_test_wpkh());
assert_eq!(wallet.get_balance().unwrap().confirmed, 0);

Expected behavior

let (wallet, _, _) = get_funded_wallet(get_test_wpkh());
assert_eq!(wallet.get_balance().unwrap().confirmed, 50000);
@rajarshimaitra rajarshimaitra added the bug Something isn't working label Aug 15, 2022
@rajarshimaitra rajarshimaitra self-assigned this Aug 15, 2022
@rajarshimaitra rajarshimaitra linked a pull request Aug 15, 2022 that will close this issue
3 tasks
@notmandatory notmandatory moved this to Ready to Review in BDK Maintenance Aug 16, 2022
Repository owner moved this from Ready to Review to Done in BDK Maintenance Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants