Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error handling #40

Open
robertkowalski opened this issue Nov 24, 2017 · 0 comments
Open

improve error handling #40

robertkowalski opened this issue Nov 24, 2017 · 0 comments

Comments

@robertkowalski
Copy link
Contributor

errors returned by grape (e.g. ERR_GRAPE_ANNOUNCE) don't have error codes and are not handled in services.

right now announcing for example doesn't care about error responses, and for a service maintainer it looks like their service would announce OK - this happens with or without error code added to the error response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertkowalski