Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF Tokens on forms #61

Open
blackfyre opened this issue Nov 3, 2023 · 4 comments
Open

CSRF Tokens on forms #61

blackfyre opened this issue Nov 3, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@blackfyre
Copy link
Owner

The title says it all...

@blackfyre blackfyre added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 4, 2023
@blackfyre blackfyre added this to the 1.0.0 milestone Nov 4, 2023
@blackfyre
Copy link
Owner Author

CSRF Tokens have to be implemented to non-API/non-Admin endpoints only.

@sanjay-xdr
Copy link

I noticed commented code related to adding a CSRF token in the files. Is there something wrong with the commented code, or should I proceed with it? Alternatively, is there another library you'd prefer to use for CSRF protection?

@blackfyre
Copy link
Owner Author

blackfyre commented Jul 29, 2024

@sanjay-xdr Welcome aboard :)

You can join us over at discord if you want to chat about it in detail 😄

Apart from that, the original implementation broke more thing than it resolved so it was essentially suspended until some one could pick it up again.
There's no preference around packages apart from keeping them at a minimum (in number), has to be maintained and echo compatibility might make one's life easier since pocketbase is built on top of it.

@christiankozalla
Copy link

I've added a pull request for this issue:
#132

But it's still work in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants