Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native menu bar #4

Closed
simmac opened this issue May 11, 2016 · 1 comment
Closed

native menu bar #4

simmac opened this issue May 11, 2016 · 1 comment

Comments

@simmac
Copy link
Contributor

simmac commented May 11, 2016

Is there any reason why you are not using the native menu bars? At least in OS X the native menu bar saves spaces and is a de-facto-standard.

See line
48: ui.menubar->setNativeMenuBar(false);
in Client.cpp

@blizzard4591
Copy link
Owner

From the Docs:

This property specifies whether or not the menubar should be used as a native menubar on platforms that support it. The currently supported platforms are OS X and Windows CE. On these platforms if this property is true, the menubar is used in the native menubar and is not in the window of its parent, if false the menubar remains in the window. On other platforms the value of this attribute has no effect.

Since I do not have Mac OS I do not see a difference between the two options, and so it seems I copied this line from somewhere and never thought about why it is there.

Fixed in 5d0c442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants