Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#![feature(custom_attribute)] prevents compilation on stable #1

Closed
Electron100 opened this issue Jan 21, 2019 · 2 comments
Closed

#![feature(custom_attribute)] prevents compilation on stable #1

Electron100 opened this issue Jan 21, 2019 · 2 comments

Comments

@Electron100
Copy link

This package cannot compile on stable Rust due to the use of #![feature(custom_attribute)] . It's unclear (to my anyway) why this feature is specified. If it is removed, the package compiles without issue on stable (1.32)

Based on the latest discussion at rust-lang/rust#29642, it appears that the custom_attribute feature is likely to be removed from nightly soon, anyway.
@blm768
Copy link
Owner

blm768 commented Jan 24, 2019

Good catch. I copied the feature flag out of an older project that been started back when #![feature(custom_attribute)] was necessary for wasm_bindgen, but it looks like that's no longer the case.

@blm768
Copy link
Owner

blm768 commented Jan 24, 2019

This should be fixed with the latest release. Thanks for reporting the issue!

@blm768 blm768 closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Electron100 @blm768