chore(refactor): refactor payment methods #6310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mperdomo-bc
requested review from
TheLeoB,
milan-bc,
jjBlockchain,
dkremniov-bc,
mrodriguez-bc and
CTucker-BC
as code owners
mperdomo-bc
force-pushed
the
payment-methods-refactor
branch
from
900432c to
ab6484f
Compare
|
No New Or Fixed Issues Found |
mperdomo-bc
force-pushed
the
payment-methods-refactor
branch
from
b388082 to
8da7b4d
Compare
jjBlockchain
previously approved these changes
Mar 7, 2024
mperdomo-bc
force-pushed
the
payment-methods-refactor
branch
from
b1af7b5 to
d5d30eb
Compare
jjBlockchain
approved these changes
Mar 7, 2024
|
@mperdomo-bc do you plan to merge this one? |
|
Potentially, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to share a lot with the
LinkedPaymentAccountsrefactor (#6309) so this refactor could be a first step towards unifying a few things here and there.