Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcdiff --list could show which tags are enabled/disabled by default #49

Closed
natanrolnik opened this issue Apr 13, 2020 · 1 comment · Fixed by #55
Closed

xcdiff --list could show which tags are enabled/disabled by default #49

natanrolnik opened this issue Apr 13, 2020 · 1 comment · Fixed by #55
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@natanrolnik
Copy link
Contributor

natanrolnik commented Apr 13, 2020

When I wanted to "filter" some tags while using xcdiff, I used xcdiff --list to print the tags. I removed 2 of them, and, to my surprise, diffing jumped from a few seconds to around 30.

I messaged @kwridan in the Tuist Slack, and he pointed me to this file: Comparators.md. Kas explained (as written in the mentioned md file) that the RESOLVED_SETTINGS tag depends on xcodebuild under the hood, and this is why this tag is disabled by default.

Ideally, listing the tags should inform the user which tags are enabled/disabled by default, so mimicking the default behavior is easier.

An example of this is the SwiftLint's rules command, which prints much more information:

SwiftLintRules

For xcdiff, a table with the tags, description, and enabled by default would be even better.

@marciniwanicki
Copy link
Contributor

+1, that could be very useful :)

@marciniwanicki marciniwanicki added enhancement New feature or request good first issue Good for newcomers labels Apr 14, 2020
marciniwanicki added a commit that referenced this issue May 30, 2020
…default (#55)

Resolves #49

Test Plan:
- CI
- Run `xcdiff --list`, ensure all except `RESOLVED_SETTINGS` comparators are listed with default value `Yes`. 

Signed-off-by: Marcin Iwanicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants